Skip to content

Fix trunk-upgrade workflow to use action-provided Trunk binary - #246

Merged
Morgy93 merged 2 commits into
mainfrom
copilot/fix-upgrade-job-failure
Aug 17, 2026
Merged

Fix trunk-upgrade workflow to use action-provided Trunk binary#246
Morgy93 merged 2 commits into
mainfrom
copilot/fix-upgrade-job-failure

Conversation

Copilot AI commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

The scheduled Trunk Upgrade workflow failed in job upgrade because trunk was invoked as if it were globally on PATH. In this runner context, trunk-io/trunk-action installs Trunk at TRUNK_PATH, so the upgrade step never found the binary.

  • Root cause

    • trunk upgrade -y --include-cli assumed shell PATH resolution.
    • The action exposes Trunk via TRUNK_PATH, not guaranteed PATH injection for later raw run steps.
  • Workflow change

    • Updated .github/workflows/trunk-upgrade.yml to invoke Trunk through TRUNK_PATH in the upgrade step.
    • Scope is intentionally minimal: single-line command fix, no behavior changes outside the upgrade job.
  • Resulting command shape

    - name: Upgrade Trunk CLI and linters
      run: '"${TRUNK_PATH}" upgrade -y --include-cli'

Co-authored-by: Morgy93 <7961978+Morgy93@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix failing GitHub Actions job upgrade Fix trunk-upgrade workflow to use action-provided Trunk binary Aug 17, 2026
Copilot AI requested a review from Morgy93 August 17, 2026 07:34
@github-actions github-actions Bot added the CI/CD label Aug 17, 2026
@Morgy93
Morgy93 marked this pull request as ready for review August 17, 2026 11:37
Copilot AI lite review requested due to automatic review settings August 17, 2026 11:37
@Morgy93
Morgy93 merged commit 8c70652 into main Aug 17, 2026
21 checks passed
@Morgy93
Morgy93 deleted the copilot/fix-upgrade-job-failure branch August 17, 2026 11:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the scheduled Trunk Upgrade GitHub Actions workflow by invoking the Trunk CLI via the path provided by trunk-io/trunk-action (TRUNK_PATH), ensuring the upgrade job can locate and execute the Trunk binary reliably on the runner.

Changes:

  • Update the upgrade step to run Trunk using TRUNK_PATH instead of assuming trunk is on PATH.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/trunk-upgrade.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants