Fix trunk-upgrade workflow to use action-provided Trunk binary - #246
Merged
Conversation
Co-authored-by: Morgy93 <7961978+Morgy93@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job upgrade
Fix trunk-upgrade workflow to use action-provided Trunk binary
Aug 17, 2026
Morgy93
approved these changes
Aug 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the scheduled Trunk Upgrade GitHub Actions workflow by invoking the Trunk CLI via the path provided by trunk-io/trunk-action (TRUNK_PATH), ensuring the upgrade job can locate and execute the Trunk binary reliably on the runner.
Changes:
- Update the upgrade step to run Trunk using
TRUNK_PATHinstead of assumingtrunkis onPATH.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scheduled Trunk Upgrade workflow failed in job
upgradebecausetrunkwas invoked as if it were globally onPATH. In this runner context,trunk-io/trunk-actioninstalls Trunk atTRUNK_PATH, so the upgrade step never found the binary.Root cause
trunk upgrade -y --include-cliassumed shell PATH resolution.TRUNK_PATH, not guaranteed PATH injection for later rawrunsteps.Workflow change
.github/workflows/trunk-upgrade.ymlto invoke Trunk throughTRUNK_PATHin the upgrade step.upgradejob.Resulting command shape