Fix notification & audit trail for dataclip retention policy changes - #5089
Open
taylordowns2000 wants to merge 4 commits into
Open
Fix notification & audit trail for dataclip retention policy changes#5089taylordowns2000 wants to merge 4 commits into
taylordowns2000 wants to merge 4 commits into
Conversation
Security Review ✅
|
taylordowns2000
commented
Aug 22, 2026
|
|
||
| defp retention_setting_updated?(changeset) do | ||
| Map.has_key?(changeset.changes, :history_retention_period) or | ||
| Map.has_key?(changeset.changes, :retention_policy) or |
Member
Author
There was a problem hiding this comment.
we didn't count changing the policy as part of the retention_setting_updated? function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #5088 by checking for a change in the
retention_policywhen deciding whether to send the policy change alert. The new functionality in this PR::erase_allThe PR also fixes #5090 (the audit trial) in exactly the same fashion.
Validation steps
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)