Exclude sandbox projects from credential's project list - #5068
Open
hirad121 wants to merge 1 commit into
Open
Conversation
Credentials automatically propagate to descendant sandboxes so runs there keep working, but the "Projects with access" table on the Settings > Credentials page showed every sandbox too, including ones already merged and deleted. That list is meant to show which top-level projects a credential is granted to, not the full propagation tree. Fixes OpenFn#4014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Excludes sandbox projects from a credential's "Projects with access" list
on the Settings > Credentials page. Credentials automatically propagate to
descendant sandboxes so runs there keep working, but that full propagation
tree was being shown in this list, including sandboxes already merged and
deleted. The list now shows only the top-level projects the credential is
actually granted to.
Closes #4014
Validation steps
credential's "Projects with access" list; the parent project still does.
(
GET /api/projects/:sandbox_id/credentials) is unaffected — that's adifferent, intentional code path and was verified unchanged.
Additional notes for the reviewer
This only touches the display list in
CredentialIndexComponent.list_credentials/1. It doesn't touchCredentials.list_credentials/1(the shared context query used by the API),the sandbox-propagation logic, or any authorization checks — full
credential and API test suites pass unchanged.
AI Usage
Pre-submission checklist