Worker: support workOrderId on meta object - #1500
Merged
Merged
Conversation
3 tasks
A leftover debug statement dumped every run plan - job code, credential ids, dataclip id - to the worker's stdout on every claim.
The test asserted workorderId against a run.meta.workorder_id that nothing sets, so it failed and broke the type check. project_id is already on the plan, so meta.projectId can work against any Lightning version, and the ids are left off entirely when Lightning doesn't send them.
This was referenced Aug 14, 2026
elias-ba
self-requested a review
August 14, 2026 16:41
elias-ba
approved these changes
Aug 14, 2026
doc-han
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the
metaglobal in a run by addingworkOrderId,workflowIdandprojectId. These are appended to the run by lightning.It is safe to run against main - users simply wont see the metadata.
The docker image will be built and uploaded to dockerhub after merging to main
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy