Repository navigation
Add feign-jdk-json codec for the JDK Simple JSON API (JEP 540) and fix Dependabot auto-merge - #3620
Merged
Merged
Conversation
… Dependabot auto-merge Signed-off-by: Marvin Froeder <velo.br@gmail.com>
Signed-off-by: Marvin Froeder <velo.br@gmail.com>
…er cleanup and naming Signed-off-by: Marvin Froeder <velo.br@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
feign-jdk-json, a codec for the JDK's built-in Simple JSON API (jdk.incubator.json, JEP 540, InfoQ), proposed to target JDK 28. It also fixes the Dependabot auto-merge job, which currently fails on every Dependabot PR.New module:
jdk-jsonJdkJsonDecoderdecodes intoJsonValueor any subtype (JsonObject,JsonArray, ...), or into the rawString. The JDK API has no data binding, so the codec works on the JSON tree.DecodeExceptioncaused byJsonParseException.DecodeException.null.JdkJsonEncoderwrites anyJsonValueas compact JSON.--add-modules jdk.incubator.json. A type-mismatch error names the JSON kind it got (e.g.a JSON array) instead of echoing the response body. Moditect is skipped because it can't handle the incubator module.Build wiring
jdk28-modulesprofile, so contributors without a JDK 28 toolchain can still build the default reactor.openjdk:28-ea-jdk, pinned by digest in.circleci/jdk28/Dockerfile. SDKMAN returns 404 for the 28 EA candidate. A newdockerentry independabot.ymllets Dependabot bump the digest when a new EA build ships. The JDK is cached under its own key (the Dockerfile checksum) in~/jdk28, so a digest bump refetches only the JDK and leaves the Maven/SDKMAN cache alone. CI also adds a toolchain entry for version 28 and runsverify,go-offlineanddeploywith-Pjdk28-modules.dependencyManagement.Build fix
auto-merge-dependabot.ymlrangh pr merge --auto --merge, but the repository now only allows squash merges. The job failed withMerge method merge commits are not allowed on this repositoryon every Dependabot PR (#3614–#3619). It now uses--squash.Caveats
Test plan
./mvnw -Pjdk28-modules verifywith a JDK 28 EA toolchain: BUILD SUCCESS.JdkJsonCodecTesthas 14 tests and all pass../mvnw -Prelease,jdk28-modules -pl jdk-json -DskipTests packagebuilds the javadoc jar.