Cache (4/5): Adopt inference caching in task runners - #124
Conversation
df52a6d to
e28ee43
Compare
269ccdf to
4f5d127
Compare
1cc01a3 to
b5ca140
Compare
595f5ce to
1389840
Compare
kargibora
left a comment
There was a problem hiding this comment.
Overall this PR looks quite clear. It wires all the things that have been implemented and removes the legacy code. It is good that we got rid of many lines that were making the code harder to parse!
| use_tqdm=use_tqdm, | ||
| inference_cache=build_completion_cache(cfg), | ||
| **extra_kwargs, | ||
| ) |
There was a problem hiding this comment.
Nice that we get rid of this!
kargibora
left a comment
There was a problem hiding this comment.
I also did not understand the reason of cache_metadata. Do we need it in , do_inference(), annotate_battles() and judge_and_parse_prefs()?
|
@kargibora Yes, it needs to reach all three in the current flow. It is not part of the cache key, but rather the info that doesn't necessarily affect determine the output e.g. We could avoid passing a separate argument by creating an object such as: What do you think? |
…to cache-on-118/03-providers # Conflicts: # judgearena/inference.py # tests/test_inference_cache.py
…cache-on-118/04-runners
…o cache-on-118/02-do-inference
…to cache-on-118/03-providers
…cache-on-118/04-runners
|
Thanks for making it clear! I think that can work |
Description
Adopts the inference cache in the task runners through
--run.store_root.do_inferencecache.ignore_cache,cache_function_dataframe, and the old cache tokens.This is stacked on #123.