Sort integration test files - #2697
Merged
Merged
Conversation
wixoaGit
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration test files were not sorted deterministically so spurious failures such as this one could happen: https://github.com/OpenDreamProject/OpenDream/actions/runs/31660207801/job/94323265328
The cause was move.dm running before bounds_dist.dm. The former caused the latter to fail because it changed world dimensions to be smaller than what the latter required.
I feel like it's still a fragile system if these kinds of dependencies are possible but at least now it's consistently fragile, and I guess the proper way to fix it would be to reset the world before each run, but that might make things slower. I haven't explored that.