Fix SQLite database queries - #2696
Open
DamianX wants to merge 2 commits into
Open
Conversation
DamianX
force-pushed
the
sqlite-query-execute-filename
branch
3 times, most recently
from
August 12, 2026 16:05
605b34f to
5ee3d76
Compare
DamianX
force-pushed
the
sqlite-query-execute-filename
branch
from
August 13, 2026 02:14
b4d3b21 to
abd94f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the following in order to make vgstation migrations and preferences actually work.
Made
GetColumn()1-indexed, as it is in BYOND.Implemented
/database/query.Execute(filename)(as opposed toExecute(database/db))Execute()now returns 1 on success and 0 on failure.Invalid
Execute()arguments raise Bad database.NextRow()now returns 1 when it advances to a row and 0 when exhausted.Re-executing a query closes its prior reader and restarts the result set.
An existing comment mentioned that /icons could be turned into BLOBs in SQLite. That turned out to be true, but BYOND, at least in the latest version, does not seem to allow retrieving BLOBs from SQLite.
So: