Update RobustToolbox to version 288.1.0 - #2693
Open
DamianX wants to merge 8 commits into
Open
Conversation
boring-cyborg
Bot
added
Client
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
DamianX
changed the title
Contributor
Author
|
The latest RT versions provide an updated SDL3 so #2571 is also fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The non-trivial change is the refactoring of DreamFilter that previously used serialization features that were changed in RT 287. I opted to write something similar to what particles do, instead of trying to hold on to ISerializationManager, which seemed inefficient and round-about either way.
The lifetimes and handling of DreamFilters in general seems highly suspicious to me but my refactoring should have kept it as suspicious as it was before, I believe.
Closes #2650 as I confirmed Tracy Just Works with the new version RT uses, though I'll admit I had never used Tracy before this so something may have slipped past me.
Closes #2571