Fix disassembling lateral proc overrides - #2690
Open
snowyukitty wants to merge 2 commits into
Open
Conversation
ike709
reviewed
Jul 30, 2026
| Console.WriteLine(proc.Decompile()); | ||
| } else if (_selectedType.Procs.TryGetValue(name, out DMProc[]? procs)) { | ||
| if (procs.Length > 1) { | ||
| Console.WriteLine($"Notice: Found {procs.Length} definitions of {name}(); decompiling all in source order."); |
Collaborator
There was a problem hiding this comment.
Personally, I'd like a second message afterwards too since I may not always scroll up past the text wall to see this one. Just a Finished decompiling all {proc.Length} definitions of {name}() or similar.
Author
|
Added a completion message after the last definition and extended the regression test to verify it appears after the final decompiled body. Thanks! |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| startInfo.ArgumentList.Add(disassembler); | ||
| startInfo.ArgumentList.Add(jsonFile); | ||
|
|
||
| using var process = new Process { StartInfo = startInfo }; |
| "ReturnFloat 3" | ||
| }), output); | ||
| Assert.That(output, Does.Contain(completion)); | ||
| Assert.That(output.Split(notice, StringSplitOptions.None), Has.Length.EqualTo(2), output); |
| }), output); | ||
| Assert.That(output, Does.Contain(completion)); | ||
| Assert.That(output.Split(notice, StringSplitOptions.None), Has.Length.EqualTo(2), output); | ||
| Assert.That(output.Split(completion, StringSplitOptions.None), Has.Length.EqualTo(2), output); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2562
Testing
dotnet build DMDisassembler/DMDisassembler.csproj --configuration Release --no-restoredotnet test DMDisassembler.Tests/DMDisassembler.Tests.csproj --configuration Release --no-build --no-restore