Repository navigation
[PATCH v4] api: crypto: add support for AAD lengths expressed in bits - #2419
Merged
MatiasElo merged 4 commits intoOct 23, 2026
Merged
Conversation
github-actions
Bot
changed the title
|
Acked-by: Tejasree Kondoj ktejasree@marvell.com |
JannePeltonen
force-pushed
the
crypto-aad-bit-mode
branch
from
October 14, 2026 11:53
3033c67 to
bf01f64
Compare
github-actions
Bot
changed the title
Collaborator
Author
|
v2:
|
| @@ -532,6 +532,11 @@ odp_crypto_session_create(const odp_crypto_session_param_t *param, | |||
| *session_out = ODP_CRYPTO_SESSION_INVALID; | |||
Collaborator
There was a problem hiding this comment.
_odp_crypto_session_print() could print the new auth_aad_len_in_bits parameter field.
Collaborator
Author
There was a problem hiding this comment.
But none of the crypto implementations in linux-gen or linux-dpdk support it, so it would always be false. I would rather add it only when/if support for the feature is added.
Collaborator
There was a problem hiding this comment.
It's for debugging purposes, no need to hide it whether it's supported or not.
TuomasTaipale
approved these changes
Oct 22, 2026
JannePeltonen
force-pushed
the
crypto-aad-bit-mode
branch
from
October 23, 2026 11:24
bf01f64 to
5e9c46d
Compare
github-actions
Bot
changed the title
Add a new crypto session parameter auth_aad_len_in_bits to indicate that AAD length is expressed in bits to support non-byte-divisible AAD lengths. Add a corresponding auth capability flag aad_len.bit_mode with default value false to indicate support for AAD length in bits. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com> Acked-by: Tejasree Kondoj <ktejasree@marvell.com>
Implement the new auth_aad_len_in_bits feature by not supporting it and by failing session creation if auth_aad_len_in_bits is requested. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com> Acked-by: Tejasree Kondoj <ktejasree@marvell.com>
Add checking of the default value of the new auth_aad_len_in_bits crypto session parameter. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com> Acked-by: Tejasree Kondoj <ktejasree@marvell.com>
Add printing of AAD bit mode when it is supported. Improve AAD length printout by printing min, max and inc labels and by grouping all AAD length capabilities. Signed-off-by: Janne Peltonen <janne.peltonen@nokia.com> Reviewed-by: Tuomas Taipale <tuomas.taipale@nokia.com>
MatiasElo
force-pushed
the
crypto-aad-bit-mode
branch
from
October 23, 2026 12:05
5e9c46d to
5c88a47
Compare
MatiasElo
enabled auto-merge (rebase)
October 23, 2026 12:05
github-actions
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new crypto session parameter auth_aad_len_in_bits to indicate that AAD length is expressed in bits to support non-byte-divisible AAD lengths. Add a corresponding auth capability flag aad_len.bit_mode with default value false to indicate support for AAD length in bits.