Repository navigation
refactor(deployment)!: consolidate assets and runtime helpers - #98
Merged
Merged
Conversation
Group container recipes and Kubernetes examples under deployment and replace duplicated launch scripts with one foreground application interface per platform. Scope stop helpers to one explicit application PID and document migration.
BREAKING CHANGE: update root Dockerfile, docker/ and kubernetes/ paths to deployment/. Replace rund and sample wrappers with run.{sh,bat} <Release|Debug> <name> <busid> [runtime-directory]; the old implicit five-service daemon launch is removed. Stop helpers now require an explicit PID; use CMake clean instead of vc_clear.bat.
Use lowercase snake_case library stems and targets for official, server and sample plugins. Update manifests and current documentation, retain platform extensions and Debug postfixes, and reject mixed-case declarations. BREAKING CHANGE: update legacy AF*Plugin and Sample*Plugin build targets and manifest library names to the corresponding snake_case stems.
nick2781
marked this pull request as ready for review
October 20, 2026 03:12
nick2781
enabled auto-merge
October 20, 2026 03:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing runtime scripts duplicated Release/Debug launch sequences, used missing configuration paths, and could terminate processes by machine-wide image patterns. Consolidate them into one explicit single-application launcher per platform and scope stop helpers to one confirmed PID. Container recipes and cluster examples now live together under
deployment/.run.* <Release|Debug> <name> <busid> [runtime-directory]interface and documented CMake clean command.Validation at integrated candidate
024b1c1dacd6e04eba0a56c090e92571e4be7422: 77 Node tests pass, shellcheck and shell syntax checks pass, deployment YAML parses and matches the approved name-only changes, Docker stage/base-recipe comparisons pass, changed local Markdown links resolve, and the full documentation check passes (123 generated HTML pages, 217 internal references). Runtime tests use temporary stub executables and never signal a real service. Windows batch execution, container builds, cluster acceptance and hosted CI have not been run.BREAKING CHANGE: update root
Dockerfile,docker/andkubernetes/references to thedeployment/paths; run Docker builds from the repository root with-f deployment/Dockerfile. Replacerund.*and sample scripts withrun.* Debug <name> <busid> [runtime-directory]. Launching one foreground application replaces the former implicit five-service daemon sequence; arrange target-environment orchestration and supply Bus IDs explicitly. Stop helpers require one application PID. Usecmake --build <build-directory> --target cleanin place ofvc_clear.bat.