Repository navigation
feat: log fields as attributes, not message text [#241] - #47
Open
hariharanweb wants to merge 2 commits into
Open
hariharanweb wants to merge 2 commits into
hariharanweb wants to merge 2 commits into
Conversation
- Each line is a short, fixed message; fields go in extra= as attributes - HyperDX can filter on workflow_id, status, uri, duration_ms and the rest - Temporal's context dict is flattened into dotted keys, not repeated in the message - Console still prints key=value, so local greps keep working - Tests read record attributes instead of message text
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…241] - Cancelling a workflow logs "workflow cancelled" at WARNING - A failed Redis push logs a warning and the sync still succeeds - Temporal's message setting moves next to the interceptor, so it applies without the worker - Fixes test_activity_logging failing when run on its own
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log fields were packed into the message text, so HyperDX could not filter on them.
extra=and export as attributestemporal_activity.workflow_id) and no longer repeated in the messagenamefields renamed toscheme_name/activity_type/workflow_type, sincenameis a reserved log keyRelates to OpenAgriNet/engineering-tracker#241
🤖 Generated with Claude Code