docs: state the real number of shipped schema files - #31
Merged
Conversation
The README said nineteen JSON files ship under openadapt_types/schemas/. Seventeen do. Nobody could have caught that by reading the diff, which is the problem worth fixing rather than the digit. So the claim now has a test behind it, along with two neighbours in the same class: every relative link in the README resolves to a real path, and every schema filename it names in backticks is one the package ships. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README rewrite in #30 says nineteen JSON files ship under
openadapt_types/schemas/. Seventeen do. It is a small error, but it isthe kind that no reviewer catches by reading a diff, and it goes stale
again on the next schema anyone adds.
So this corrects the number and puts a test behind it, plus two more in
the same class:
The count test fails with
README says 'nineteen' JSON files ship under schemas/, but 17 are there. Write 'seventeen'.against the text this PRreplaces, so it catches the exact thing that got through.
docs:on purpose. This is README-only and does not need a version bump.Note on the red main this came out of
Unrelated to this PR, and already clear.
Release and PyPI Publishfailedon main on Aug 26 and Aug 27 with
type object 'Actor' has no attribute 'name_email_regex'. GitPython 3.1.60 removed that attribute on Aug 25;python-semantic-release reads it at
cli/config.py:651, and its action isa Docker action that resolves
gitpython~=3.0fresh on every run. GitPython3.1.61 put the attribute back this morning. Re-running the same failed run
at the same commit, with no repo change, went green on 3.1.61: run
33113408431.