Bind Ops workflows to separate App identities - #152
Draft
abrichr wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Ops still lets scheduled and manual workflows use broad repository identities. The Docs sync also writes to
main. That model can't enforce the separate lifecycle, Docs, backup, and operator authorities required by the target-state protection policy.What changed
The lifecycle projection now accepts only the configured lifecycle App identity. The Docs sync accepts only the configured Docs App identity. Both verify the actor, App, installation, source commit, and idempotency inputs.
Docs generation now pushes one automation branch and opens a pull request. Its workflow token never writes to
main. The Production lifecycle check runs on every pull request.The eight other manual workflows reject the lifecycle App before any effect job can start. Their concurrency keys include the workflow and event, and they don't cancel an active effect run.
Do not merge yet
This branch doesn't create an App, environment, protection rule, or branch. The exact App identities, repository installations, variables, private keys, and protected environments must exist before these workflows can run. PR #151 must then bind the final workflow files and exact identities before protection is applied.
Checks