fix(db): retry transient SQLite writer locks - #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Capture now retries an insert when another SQLite writer holds the per-capture database lock for a short time. It rolls back the failed transaction before each retry and stops after two retries. If the lock remains, the writer still exits with an error and Recorder reports that failure.
The SQLite connection's existing five-second lock wait is now explicit. The total database wait is bounded at about 15.25 seconds.
Why
A Windows live-recorder run failed when the memory-stat process hit a database lock while other capture writers were committing. This change lets a short conflict clear. It doesn't accept a partial database or hide a writer failure.
Test evidence