Repository navigation
Conversation
…alues in ruby-nextgen Signed-off-by: Inf1mum <vadimlazuk5@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25724
Validations#validate_attributechecked patterns withvalue !~ rules[:pattern]without a type guard;Object#=~was removed in Ruby 3.2, so a non-String value in a pattern-constrained attribute raisedNoMethodErrorfromnew/valid?instead of being reported invalid.The guard is now
rules[:pattern] && (!value.is_a?(String) || value !~ rules[:pattern])— non-String values are reported invalid with the standard message, matching the issue's expected output.Generator test + spec fixture assert the guarded line and
pattern:emission; ruby-nextgen petstore/qdrant samples regenerated (one line each).RubyNextgenClientCodegenTest25/25 green; negative check confirmed the test fails without the guard.Summary by cubic
Prevents
ruby-nextgenpattern validation from raisingNoMethodErrorwhen a constrained attribute contains a non-String value. Such values are now reported invalid with the standard validation message.Written for commit 3378a50. Summary will update on new commits.