Repository navigation
Remove unused private methods and commented-out code - #25602
Open
ChihweiLHBird wants to merge 1 commit into
Open
ChihweiLHBird wants to merge 1 commit into
ChihweiLHBird wants to merge 1 commit into
Conversation
ChihweiLHBird
force-pushed
the
cleanup/remove-dead-private-methods
branch
6 times, most recently
from
November 18, 2026 07:11
9ae4a1c to
6fd16bd
Compare
ChihweiLHBird
force-pushed
the
cleanup/remove-dead-private-methods
branch
from
November 19, 2026 17:43
6fd16bd to
3fed5f8
Compare
ChihweiLHBird
force-pushed
the
cleanup/remove-dead-private-methods
branch
from
November 20, 2026 07:56
3fed5f8 to
5987ecd
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes private methods that nothing calls, plus the constants and commented-out code that only existed for them. Generated output is unchanged.
InlineModelResolver:fixStringModelwith its helpersschemaIsOfTypeandschemaContainsExample, andmakeSchema(replaced bymakeSchemaInComponentsin [Inline model resolver] better handling of inline responses and bug fixes #12353; only a commented-out call was left)AbstractApexCodegen:sanitizePackageName,sanitizePath, the commented-outgetAcceptblock and the GuavaStringsimportAbstractAdaCodegen:isMimetypeOctetStreamandAPPLICATION_OCTET_STREAMRustServerCodegen,RustServerCodegenDeprecated:isMimetypeOctetStream(andoctetMimeTypeinRustServerCodegen)KotlinServerCodegen:isKtor2(onlyisKtor2Or3is used)CppOatppClientCodegen,CppOatppServerCodegen:postProcessSingleParamMost were never called since they were added (copied from another generator or migrated from swagger-codegen); the
InlineModelResolverand Rust ones lost their last caller in earlier refactors.CC committee members
cc technical committee members for the touched generators (Apex has none listed):
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Removes private methods, constants, and commented-out code that nothing calls so the dead code no longer looks like it should be used. Generated output is unchanged; most removed methods were never called since they were added, and the
InlineModelResolverand Rust ones lost their last caller in earlier refactors.InlineModelResolver: removesfixStringModeland its helpers,makeSchema, and a commented-out call.isKtor2,postProcessSingleParam, and commented-outsanitizePathblocks.Written for commit 5987ecd. Summary will update on new commits.