Repository navigation
[core] Extract InlineModelResolver's repeated inline-model step into a helper - #25554
Open
ChihweiLHBird wants to merge 1 commit into
Open
ChihweiLHBird wants to merge 1 commit into
ChihweiLHBird wants to merge 1 commit into
Conversation
ChihweiLHBird
force-pushed
the
refactor/inline-model-resolver-extract-inline-model
branch
2 times, most recently
from
November 10, 2026 05:56
d1fadb9 to
88f729a
Compare
ChihweiLHBird
force-pushed
the
refactor/inline-model-resolver-extract-inline-model
branch
6 times, most recently
from
November 19, 2026 17:36
b70e969 to
506a8de
Compare
…a helper Signed-off-by: Zhiwei Liang <zhiwei.liang@zliang.me>
ChihweiLHBird
force-pushed
the
refactor/inline-model-resolver-extract-inline-model
branch
from
November 20, 2026 07:48
506a8de to
b71155d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor of
InlineModelResolver; generated output is unchanged.Eight call sites repeated the same steps: resolve a model name, recurse with
gatherInlineModels, and move the schema to the components withmakeSchemaInComponentswhenisModelNeededsays so. They now call one privateextractInlineModelhelper, which keeps the call order. The allOf site is left as is because it also depends onREFACTOR_ALLOF_INLINE_SCHEMAS.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
Summary by cubic
Refactors
InlineModelResolverby extracting the repeated sequence of resolving a model name, recursing withgatherInlineModels, and moving the schema to components when needed into a single privateextractInlineModelhelper. This removes duplication across eight call sites without changing the generated output.The helper returns the new
$refschema, ornullwhen the schema stays inline, so callers check fornullinstead of callingisModelNeededthemselves. The allOf branch is left as is because it also depends onREFACTOR_ALLOF_INLINE_SCHEMAS. The helper keeps the original call order, which matters becauseresolveModelNamedoes not reserve the name it returns.Written for commit b71155d. Summary will update on new commits.