Skip to content

fix: add support for nullable arrays in Swift 5,6 - #24770

Open
HarelM wants to merge 3 commits into
OpenAPITools:masterfrom
HarelM:issue-22355
Open

fix: add support for nullable arrays in Swift 5,6#24770
HarelM wants to merge 3 commits into
OpenAPITools:masterfrom
HarelM:issue-22355

Conversation

@HarelM

@HarelM HarelM commented Aug 24, 2026

Copy link
Copy Markdown

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

CC: @jgavris @ehyche @Edubits @jaz-ah @4brunu @dydus0x14


Summary by cubic

Respect nullable array items in Swift 5 and 6 generators, and nullable map values in Swift 6, so generated types match OpenAPI nullability. Previously arrays/sets and maps used non-optional element/value types; now nullable items/values become optionals (e.g., [String?], Set<String?>, [String: Foo?]).

  • Affected generators: Swift5ClientCodegen (arrays/sets) and Swift6ClientCodegen (arrays/sets and map values); non-nullable items are unchanged.
  • Detects nullability via nullable: true, x-nullable, and $ref/aliased schemas, including nested collections.
  • Breaking change: callers must handle nil elements and map values where schemas mark items as nullable.

Written for commit ecc7b3f. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 6 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [SWIFT] Array items cannot be nullable

2 participants