Repository navigation
chore: restrict workflow permissions and tighten feed script removal - #1809
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Integration, Lint and Weekly workflows now set
permissions: contents: readat the top, so their jobs get a read-onlyGITHUB_TOKENby default. The Weekly links job keeps its own block, which still grantsissues: writefor the broken-links report.feedHtmlinsrc/feeds.tsnow removes<script>elements in any case, with attributes on the closing tag, and repeats until none is left.What was done
permissionsblock. Nothing in them pushes withGITHUB_TOKEN. The showcase job reads public data through GraphQL, and its PR goes throughSHOWCASE_PR_GITHUB_TOKEN, so it doesn't need write access.iflag and accepts</script >or attributes on the end tag, inside a loop that stops when the string no longer changes. A new test intests/feeds.test.tscovers an uppercase tag and a nested one.feed.jsonwith the live one. No article has a script element, so the feed content doesn't change. The only difference is the code-highlighting colours in one article, which script removal can't touch.npm run prettier:check,npm run spellcheck,npm run test -- --run(79 passed),npm run build,npm run links.How to review
🤖 Generated with Claude Code