-
Notifications
You must be signed in to change notification settings - Fork 6
Translate the new-format network tables to buses and links #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nick-gorman
wants to merge
8
commits into
main
Choose a base branch
from
translate-network-to-buses-links
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c767741
Translate the new-format network tables to buses and links
nick-gorman 0a40ca4
Resolve network-table wildcards and carry all link limits per snapshot
nick-gorman 1441720
Cover expansion-table combinatorics, cost wildcards and drop logging
nick-gorman 1f2db94
Merge branch 'rename-transmission-default-limit' into translate-netwo…
nick-gorman 08a0841
Rename static_limits to max_capacities
nick-gorman df29f1d
Filter designed drops before wildcard resolution and act on review fi…
nick-gorman bd76163
Update src/ispypsa/translator/network.py
nick-gorman 3e7bf2e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I get what this function is doing but this docstring is confusing to me! Definitely a personal preference thing I think but tbh I'd find a more basic set of input descriptions clearer in this case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(The module docstring in network.py does make this clearer - but as it's a helper I kinda think shouldn't need that?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep fair comment.