Skip to content

chore(leaderboard): temporarily hide Daily Leaderboard - #335

Merged
FlyM1ss merged 3 commits into
Open-Finance-Lab:mainfrom
JinBoatus1:hide/daily-leaderboard-ui
Aug 15, 2026
Merged

chore(leaderboard): temporarily hide Daily Leaderboard#335
FlyM1ss merged 3 commits into
Open-Finance-Lab:mainfrom
JinBoatus1:hide/daily-leaderboard-ui

Conversation

@JinBoatus1

Copy link
Copy Markdown
Collaborator

Summary

  • Temporarily hide the Daily Leaderboard tab (and About blurb); ?view=daily redirects to Competition Leaderboard
  • Pause the nightly refresh cron; keep backend + manual workflow_dispatch
  • Backend/API and leaderboard.js left in place for a later re-enable

Test plan

  • Competition page shows no Daily Leaderboard subtab
  • Opening ?view=daily lands on Competition Leaderboard
  • Contest board still loads normally
  • pytest dashboard/backend/tests/test_frontend_daily_leaderboard.py -v

Park the tab and pause the nightly refresh schedule until model curves deploy reliably; keep backend and workflow_dispatch.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@JinBoatus1 is attempting to deploy a commit to the allan-feng's projects Team on Vercel.

A member of the Team first needs to authorize it.

@FlyM1ss

FlyM1ss commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Heads-up from #348 — this PR's cache busters need raising before merge.

main currently serves app.js?v=88 / styles.css?v=87; this branch ships 78 / 86. Both are numbers that already shipped, so returning browsers would keep running their cached bundle and never pick up the app.js change here.

That's also why Backend tests is red: test_cache_busters_bumped still asserts app.js?v=77 from this branch's base. Worth knowing that the guard is only checking app.html against the test file — it does not compare against main (#347), so setting the assert to 78 would turn it green while leaving the stale-cache problem in place.

Fix is to pick a number above whatever main serves at merge time in both app.html and the guard. #341 is currently sitting on 98/97, so re-check the floor rather than hardcoding off this comment.

FlyM1ss added a commit that referenced this pull request Aug 14, 2026
The Daily Leaderboard tab is gone, so the 22:30 UTC cron would keep
deploying every competition LLM nightly, billable, for a board with no
surface. Endpoint, secret and workflow_dispatch all stay -- the season
engine's nightly advance is this same call.

Adopts the pause from #335 so this PR supersedes it rather than
conflicting with it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L9cV2UzLgdTVmwcHLAtJeA
@FlyM1ss

FlyM1ss commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Heads-up on an overlap, not a request to change anything here.

#352 (draft) replaces the Daily Leaderboard tab with a two-week Live Season board, following the design Felix and @JinBoatus1 discussed. It touches every region this PR touches — the daily: nav-map entry, migrateSavedNavState, the subtab button, the About card, viewParamForNavState, showCompetitionPanel — plus it renames test_frontend_daily_leaderboard.py, which this PR adds to. So they conflict rather than compose, and whichever lands second needs a rebase.

The cron pause from this PR is carried over in #352 (c53e598), since a board with no tab should not be deploying models nightly either way.

Full comparison: #352 (comment) — ordering is yours and Felix's call.

FlyM1ss and others added 2 commits August 15, 2026 11:12
# Conflicts:
#	dashboard/frontend/app.html
#	dashboard/frontend/app.js
The branch bumped app.js 77 -> 78 in app.html but left
test_cache_busters_bumped pinned at 77, so Backend tests were red on
every push. Merging main moved the floor to 101; this branch's app.js
edit needs the next number, so app.html now ships ?v=102 and the guard
asserts it. styles.css is untouched here and stays at 101.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@FlyM1ss
FlyM1ss merged commit 913f4a2 into Open-Finance-Lab:main Aug 15, 2026
6 checks passed
FlyM1ss added a commit that referenced this pull request Aug 15, 2026
#335 hid the Daily Leaderboard subtab and paused its nightly cron. This
branch removes that tab outright and puts the season board in its place,
so every region #335 touched is rewritten here rather than combined:

- nav map / migrateSavedNavState: 'daily' now aliases to the season tab
  instead of falling through to Competition, so a deep link lands on the
  successor board rather than silently on a different one.
- showCompetitionPanel / navigateToPage / viewParamForNavState: same,
  plus the 'live' key.
- the subtab and the About card are deleted, not hidden.
- test_frontend_daily_leaderboard.py: deleted with the tab it pinned.
  Its one new case asserted the subtab carried `hidden`; the replacement
  file asserts the tab is absent from the UI entirely, which is strictly
  stronger. The other assertions were preserved through the rename.
- cache-buster floor keeps this branch's higher values (110/111), which
  clear main's merged 102/101.

The cron pause is kept as #335 wrote it, with the comment rewritten to
say why the schedule is off now: the board it fed no longer exists, and
the season engine's nightly advance is this same endpoint.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L9cV2UzLgdTVmwcHLAtJeA
FlyM1ss added a commit that referenced this pull request Aug 15, 2026
Pair each board response with its own request (sequence guard + commit the
rendered board at the single render entry point), repaint the chrome on the
error path and before the fetch, and anchor every preview disclaimer on
evidence a season advanced rather than on the period string.

Also: drop the unreachable daily_status notice/poll machinery and its three
tests, remove the #335 daily->leaderboard redirect that undid the live alias,
hide Competition-only chrome on the live board, qualify the home blurb,
separate "API unreachable" from "no models ranked yet", take the user agent
off the Race illustration, widen the brokered-claim guard to every landing
component behind an explicit disclaimer allowlist, give the cache-buster
invariant one owner, and default the manual refresh to no model deploys.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants