Skip to content

fix: [SDK-5065] report unbuildable log requests as a permanent failure #1727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abdulraqeeb33 merged 1 commit into from
Aug 26, 2026
Merged

fix: [SDK-5065] report unbuildable log requests as a permanent failure #1727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion iOS_SDK/OneSignalSDK/OneSignalOSCore/Source/Logging/OneSignalLogHttpSender.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,15 @@ import Foundation
/// Sends the KMP logger's encoded OTLP requests using the native URL loading system.
final class OneSignalLogHttpSender: ILogHttpSender {
private static let requestTimeout: TimeInterval = 10
/// The request was sent and got no usable response — DNS, timeout, socket reset. The
/// shared retry policy treats this as transient and will try again.
private static let transportFailureStatusCode: Int32 = -1
private static let disabledStatusCode: Int32 = -2
/// The request could never be built, so retrying cannot help. Kept distinct from
/// `transportFailureStatusCode` because the shared policy classifies anything it does not
/// recognise as permanent — reusing -1 here would burn the whole retry budget, on every
/// batch, against a misconfiguration that will not fix itself.
private static let invalidRequestStatusCode: Int32 = -3
private static let maximumDiagnosticBodyLength = 500
private static let defaultSession: URLSession = {
let configuration = URLSessionConfiguration.default
Expand Down Expand Up @@ -91,7 +98,7 @@ final class OneSignalLogHttpSender: ILogHttpSender {
completionHandler(
LogHttpResponse(
success: false,
statusCode: Self.transportFailureStatusCode,
statusCode: Self.invalidRequestStatusCode,
message: "Invalid log request URL"
),
nil
Expand Down