Skip to content

refactor: clean up generator, floor and command line code - #126

Merged
Joltras merged 8 commits into
devfrom
refactor/cleanup
Nov 2, 2026
Merged

Joltras merged 8 commits into
devfrom
refactor/cleanup

Conversation

@Joltras

@Joltras Joltras commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Proposed changes

This removes dead code and unused attributes, fixes the has_boss_room_as_neighbour typo, passes the floor dimensions to the generator's initial floor in the right order and simplifies several helpers that duplicated what Direction already provides. Room indexing now raises IndexError for invalid indices so rooms can be unpacked into their coordinates, and the output file is closed with a context manager. The command line now uses argparse, shows the correct default floor id and prints the actual path of the saved file. It also no longer imports Tkinter unless the UI is requested, so it works on systems without Tkinter, while generated floors stay identical for all seeds.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@Joltras
Joltras merged commit dd5aff1 into dev Nov 2, 2026
4 checks passed
@theEvilReaper
theEvilReaper deleted the refactor/cleanup branch November 3, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant