Repository navigation
chore: split dependencies and slim down the docker image - #125
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Runtime and development dependencies are now split into requirements.txt and requirements-dev.txt, so linters and test tools no longer end up in the Docker image. Uvicorn is now listed as a regular dependency instead of being installed separately. The separate starlette pin was removed because fastapi already pins a compatible version, and the response class is now imported from fastapi. The Docker image no longer installs Tkinter, only copies the source code, runs as an unprivileged user and starts the app as controller:app, which avoids loading modules under two different names. Coverage files are now ignored by git.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply