Repository navigation
fix: resolve several bugs in the tkinter ui - #124
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The canvas was sized with the room width squared, making it over 14000 pixels wide, and now matches the floor size. The right arrow key bypassed the generator's floor tracking, so saving afterwards stored the previous floor, and the menu shortcuts were only displayed but never bound. Pressing enter in the next seed field only changed the displayed seed without generating anything, and now generates a floor with the entered seed. Step by step drawing now uses the tkinter event loop instead of a background thread, which avoids calling tkinter from another thread and stops the previous drawing when a new floor is generated.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply