Repository navigation
fix: make floor json round trip lossless - #123
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The floor JSON was built by concatenating strings, so seeds containing quotes produced invalid JSON, and it is now generated with json.dumps while keeping the same keys and structure. Loading a floor did not restore the floor grid or the room id counter, which broke neighbour checks and caused duplicate ids for new rooms, and both are now rebuilt from the loaded rooms. Teleport rooms now store their connected room id and are restored as teleport rooms, while older files without that field still load as before. Opening a floor in the UI also dropped all doors and teleport connections, which are now kept as well.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply