Skip to content

chore(ci): run flake8, mypy and black in ci - #122

Merged
Joltras merged 6 commits into
devfrom
chore/ci-lint-and-typecheck
Nov 2, 2026
Merged

Joltras merged 6 commits into
devfrom
chore/ci-lint-and-typecheck

Conversation

@Joltras

@Joltras Joltras commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Proposed changes

The CI only ran pytest and pylint although flake8, mypy and black were already listed in the requirements, so it now runs all of them. To make mypy pass, the misused TypeVars were replaced with the actual Floor and Room types, missing annotations and None checks were added, and the legend window now imports globals through the same path as all other modules. The code base was formatted once with black so the new formatting check starts green, and generated floors stay byte-identical. The invalid PR workflow also referred to a develop branch that does not exist and now points to dev.

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

@Joltras
Joltras merged commit 40ab75e into dev Nov 2, 2026
4 checks passed
@theEvilReaper
theEvilReaper deleted the chore/ci-lint-and-typecheck branch November 3, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant