Repository navigation
chore(ci): run flake8, mypy and black in ci - #122
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The CI only ran pytest and pylint although flake8, mypy and black were already listed in the requirements, so it now runs all of them. To make mypy pass, the misused TypeVars were replaced with the actual Floor and Room types, missing annotations and None checks were added, and the legend window now imports globals through the same path as all other modules. The code base was formatted once with black so the new formatting check starts green, and generated floors stay byte-identical. The invalid PR workflow also referred to a develop branch that does not exist and now points to dev.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply