Repository navigation
fix(api): return floor json directly and stop blocking the server - #121
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The API wrote every generated floor to a file in the working directory that was never cleaned up, so it now returns the JSON directly with the same body and headers as before. The CORS setup reflected any origin while allowing credentials, which the API does not need, so credentials are now disabled. Each generator now uses its own random number generator instead of the global one, which keeps all seeds producing identical floors and makes concurrent generation safe. With that in place, the generation endpoints are synchronous so FastAPI runs them in its thread pool instead of blocking the event loop.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply