Repository navigation
fix: correct teleport boss room placement - #120
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
When the boss room had to be moved behind a teleport room, the generator checked one corner but moved the room into a different one, so the boss room could end up next to other rooms or on top of an existing one. The moved boss room is now placed in the corner that was actually checked, or in any other free cell without neighbours, and is registered in the floor grid. If no such cell exists, the boss room stays in place and no teleport room is added. Additionally, TkinterTeleportRoom now stores the connected room id correctly instead of the room type, which was caused by its base class order.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply