Repository navigation
fix: prevent generator hang and reject negative floor ids - #119
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The secret room placement could loop forever when no valid position existed, which hung roughly 18% of floor 0 generations and blocked the whole API, since the endpoints run synchronously inside async handlers. The loop now stops once no position with at least one neighbour is found, and all previously working seeds produce identical floors. Negative floor ids now raise a ValueError in the generator and return 422 from the API instead of crashing with a 500. Regression tests cover the hanging seeds and the new validation, and httpx was added to requirements.txt because FastAPI's TestClient needs it.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that apply