Repository navigation
ci: fix the NDK flake and skip native builds on JS-only changes - #28
Merged
Merged
Conversation
- install ndk, platform and build-tools with sdkmanager before gradle, with retries that clear partial downloads (the 'zipfile unknown archive' flake) - build an app natively only when its android/, ios/, gemfile or package.json change, per platform; lockfile and ci changes still build everything - move the app-picking logic to .github/scripts/changed-apps.sh with a test - skip the native roll-up when the whole run is cancelled by a newer push - build ios for arm64 only and skip the index store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
platforms;android-36andbuild-tools;36.0.0withsdkmanagerbefore Gradle runs, retrying up to 3 times and clearing partial downloads between attempts. Gradle used to download the NDK mid-build, and one corrupt download (Error on ZipFile unknown archive) failed every Gradle retry. That flake failed 4 runs in 3 days, including the first run onmainafter ci: only build native apps a PR changes #26.App.tsx,src/,packages/) no longer start native builds.apps/<name>/android/→ Android only.ios/orGemfile*→ iOS only.package.json→ both..github/still build every app on both platforms.checkkeeps its current scoping..github/scripts/changed-apps.sh. Thechangesjob runs its test,changed-apps.test.sh, first (13 cases).nativeroll-up: nowif: !cancelled(). When a newer push supersedes a run, the roll-up is skipped instead of failing, so old commits don't go red. A single job cancelled by its timeout still fails it.ONLY_ACTIVE_ARCH=YES ARCHS=arm64 COMPILER_INDEX_STORE_ENABLE=NO. One simulator architecture, and no index store.