feat: deploy rollup creator#9
Open
alxdca wants to merge 1 commit into
Open
Conversation
The target branch moved init orchestration into @arbitrum/testnode-core, so the rollup-creator feature is ported into the migrated core init steps instead of keeping the old CLI-owned implementation. Docker now provisions local RollupCreator contracts and stake tokens, while Chain SDK creates the L2 and L3 rollups through those deployed contracts. Constraint: testnode-workspace-migration makes apps/cli/src/commands/init.ts a thin wrapper around core init-runner Rejected: Keep the target branch Docker create-rollup-testnode flow | it would drop the feature branch SDK rollup creation behavior Rejected: Restore the old CLI-local init implementation | it would undo the workspace migration Confidence: high Scope-risk: moderate Directive: Keep rollup deployment behavior in packages/core/src/init after the workspace split; do not move it back into apps/cli Tested: pnpm exec biome check apps/cli/src/commands/init.ts apps/cli/test/no-docker-rollup.test.ts docker/deploy-rollup-creator.ts packages/core/src/init/chain-steps.ts packages/core/src/sdk-chain.ts packages/core/src/token-bridge.ts packages/core/test/token-bridge.test.ts Tested: pnpm build Tested: pnpm typecheck Tested: pnpm test:run Not-tested: pnpm validate is blocked by pre-existing .omx JSON formatting diagnostics from the repository-wide Biome glob Co-authored-by: OmX <omx@oh-my-codex.dev>
alxdca
force-pushed
the
feat/add-rollup-creator
branch
from
2ebc67c to
356db03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RollupCreatorbefore creating both the L2 and L3 rollups, then pass the deployedRollupCreatorand stake token into SDK rollup creation.nitro-contractsandtoken-bridge-contractsrevisions and writesrollup_creator.jsoninto the testnode config.RollupCreatoraddress override, custom retryable fee handling, custom fee token allowance approval, and stake token normalization.ts-node, disable contract verification for local deploys, register the WETH gateway when needed, and use owner keys for L2/L3 bridge deployment.Why / Context
RollupCreatorinstead of relying on the default SDK deployment path.nitro-contracts, so the branch packages that deployment environment in Docker for reproducibility.