Honour a feature toggle to ignore AzureWebApp PreservePaths - #2121
Merged
Conversation
Adds AzureWebAppIgnorePreservePathsFeatureToggle to the OctopusFeatureToggles known slugs, and guards the --preservePaths MSDeploy shim argument with it in NetCoreWebDeploymentExecutor. Lets Octopus Server remotely suppress the undocumented Octopus.Action.Azure.PreservePaths variable to help gauge how many customers rely on it.
zentron
marked this pull request as ready for review
August 7, 2026 02:44
NickJosevski
reviewed
Aug 7, 2026
| if (!OctopusFeatureToggles.AzureWebAppIgnorePreservePathsFeatureToggle.IsEnabled(variables)) | ||
| { | ||
| args.Add($"--preservePaths={string.Join("|",preservePaths.Select(s => $"\"{s}\""))}"); | ||
| var preservePaths = variables.GetStrings(SpecialVariables.Action.Azure.PreservePaths, ';'); |
Contributor
There was a problem hiding this comment.
it's annoying when indentation changes make this look like a bigger diff and not just wrapped by an if, I thought the GitHub diff had gotten better
NickJosevski
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AzureWebAppIgnorePreservePathsFeatureToggle to the OctopusFeatureToggles known slugs, and guards the
--preservePathsMSDeploy shim argument with it in NetCoreWebDeploymentExecutor. Lets Octopus Server remotely suppress the undocumented Octopus.Action.Azure.PreservePaths variable to help gauge how many customers rely on it.