Skip to content

feat: expose maintenance checks in GitHub Action input#889

Open
rksharma-owg wants to merge 1 commit into
OWASP:mainfrom
rksharma-owg:codex/action-check-maintenance
Open

feat: expose maintenance checks in GitHub Action input#889
rksharma-owg wants to merge 1 commit into
OWASP:mainfrom
rksharma-owg:codex/action-check-maintenance

Conversation

@rksharma-owg

Copy link
Copy Markdown

Summary

Add a first-class GitHub Action input for maintenance checks:

  • Adds check-maintenance input to action.yml with default false.
  • Resolves input into shell environment and passes --check-maintenance to the scan command.
  • Updates GitHub Action docs in website/docs/github-action.md.
  • Adds a regression test (tests/github-action.test.ts) asserting the input is present and wired.

Validation

npm test -- tests/github-action.test.ts currently fails before this change due an existing TypeScript type issue in global build fixtures (src/utils/network.ts missing preconnect on injected fetch type).

@rksharma-owg
rksharma-owg requested a review from sonukapoor as a code owner July 25, 2026 01:23

@sonukapoor sonukapoor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice @rksharma-owg - the check-maintenance Action input is wired exactly right: it mirrors the check-overrides pattern, is properly gated (only appended when true), does not conflict with offline mode, updates github-action.md, and even adds the first-ever test for action.yml. That part is ready.

One thing to fix before it can merge: the PR bundles an unrelated commit (9e07d6b) that adds overrides: { "brace-expansion": "5.0.8" } to package.json plus jest/ts-jest bumps. That advisory (GHSA-mh99-v99m-4gvg) is already resolved on main - we handled it via the ratcheting baseline in #897, which is our documented preference over a package.json override for a transitive dev-only finding. Could you drop that commit and rebase so this PR is just the Action-input change? Once it is off, this is good to go. Thanks!

@rksharma-owg
rksharma-owg force-pushed the codex/action-check-maintenance branch from 9e07d6b to 9b3acb4 Compare July 26, 2026 19:31
@rksharma-owg

Copy link
Copy Markdown
Author

Thanks for the review. I removed the dependency/override commit and rebased the Action change onto current main. The PR now contains only action.yml, its focused contract test, and the GitHub Action documentation update.

Validation:

  • tests/github-action.test.ts — 1/1 passed
  • git diff --check — passed

The local full build still encounters the unrelated typeof fetch/preconnect error tracked in #885 and #886. CI is running on commit 9b3acb4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants