fix: two small issues in skipped manifest dependencies section#849
Merged
Conversation
…s icon skipped is typed string[] (non-optional), so the !skipped check could never be true. The new "Skipped manifest dependencies" section also reused the existing "Skipped findings" card's icon; switched to a distinct symbol so both sections are visually distinguishable. Closes #842
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small follow-up fixes to the skipped manifest dependencies feature from #841, both in
src/output/html-reporter.ts:!skipped ||null guard onrenderSkippedDependenciesSection. The parameter is typedstring[](non-optional), so the check could never be true and misled anyone reading it alongside the type signature.⊘to⊖. The existing "Skipped findings" card already uses⊘, so a report containing both sections showed two identical icons for two different concepts.Closes #842