#14104 Fix property/preferences dialog size handling#14110
Open
magnesj wants to merge 2 commits into
Open
Conversation
jonjenssen
approved these changes
Jun 4, 2026
Override sizeHint() and minimumSizeHint() in PdmUiPropertyViewDialog so the dialog cannot open collapsed. The inner scroll area reports an artificially small minimum size hint that some window managers honor literally, shrinking the dialog to an unusable size (issue #14104). The floor is capped by the content's preferred size so intentionally small dialogs are not enlarged.
Persist the geometry of PdmUiPropertyViewDialog and RiuPropertyViewTabWidget to the application settings on close and restore it on the next show. Restoring is done in showEvent rather than the constructor so it is applied reliably for a modal dialog. The settings key includes the bound object class keyword so distinct dialogs that share a window title do not collide. This behaviour is gated behind a new "Remember Dialog Size" experimental feature, disabled by default. PdmUiPropertyViewDialog cannot access RiaPreferencesSystem, so the application pushes the current setting via the static enableGeometryPersistence(), following the existing pattern used for class-name display. RiuPropertyViewTabWidget queries the feature directly.
magnesj
force-pushed
the
fix/14104-property-export-dialog-size
branch
from
462511e to
0050df4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14104
The property export dialog could open at a very small size on some window manager configurations (observed on certain RHEL8 setups). The change is split into two commits.
Add minimum size floor to property view dialog
PdmUiPropertyViewDialognever asserted a size, and the inner scroll area reports an artificially small minimum size hint that some window managers honor literally, collapsing the dialog. The dialog now overridessizeHint()andminimumSizeHint()to provide a sensible floor that the window manager cannot collapse. The floor is capped by the content's preferred size so intentionally small dialogs are not enlarged. This fix is always active.Remember user-defined size of property and preferences dialogs
The dialog size is persisted for both
PdmUiPropertyViewDialogand the Preferences dialogRiuPropertyViewTabWidget. The geometry is saved to the application settings on close and restored on the next show, so a user-adjusted size is remembered across sessions. Restoring is done inshowEventrather than the constructor so it is applied reliably for a modal dialog. The settings key includes the bound object class keyword so distinct dialogs that share a window title do not collide.This persistence is gated behind a new "Remember Dialog Size" experimental feature, disabled by default.
PdmUiPropertyViewDialogcannot accessRiaPreferencesSystem, so the application pushes the current setting via the staticenableGeometryPersistence(), following the existing pattern used for class-name display.RiuPropertyViewTabWidgetqueries the feature directly.