Bound GitHub drain operations#163
Merged
Merged
Conversation
athena-omt
approved these changes
Jul 11, 2026
athena-omt
left a comment
Contributor
There was a problem hiding this comment.
Governance review: I refreshed the branch first because it was behind; live head 11dcf63 has now completed fresh CI successfully, and auto-merge is already enabled.
I reviewed the bounded GitHub request wrapper, drain deadline/retry behavior, stable absence handling after runner deletion, shell curl/API timeouts, and updated tests. I did not find a blocker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retry-After, without blindly retrying token POSTscurland embedded GitHub App token requestsValidation
pnpm exec vitest run test/github.test.ts test/drain.test.ts test/cli.test.ts(93 tests passed)CI=true bash scripts/ci/run-fast-checks.sh(48 files, 268 tests; lint and build passed)bash -n scripts/lib/github-runner-common.shgit diff --checkSynology / GitHub Impact
This is a mergeable prerequisite for #152 and #155, not their final closure. The follow-up integration must wire plane-specific service/worker quiescence into the new callback and bound remaining CLI, SSH, SCP, repository, workflow, and container-package operations before those issues close.
Refs #152
Refs #155