Make the required CI gate fail closed#162
Merged
Merged
Conversation
Classify behavior, documentation, and unknown paths explicitly so source, deployment, dependency, and unrecognized changes cannot satisfy branch protection without meaningful checks. Align extended validation and bootstrap metadata with the pnpm and Node 24 project baseline. Closes #148
athena-omt
approved these changes
Jul 11, 2026
athena-omt
left a comment
Contributor
There was a problem hiding this comment.
Governance review: live head 0f8150e is fresh enough for review, required checks are green, and auto-merge is already enabled.
I reviewed the fail-closed CI gate classification for behavior/docs/unknown changes, same-repo vs fork job expectations, and the workflow/bootstrap contract tests. I did not find a blocker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm exec vitest run test/workflow.test.ts(14 tests passed)CI=true bash scripts/ci/run-fast-checks.sh(48 files, 268 tests; lint and build passed)actionlint(passed with known custom-runner-label diagnostics ignored)git diff --checkSynology / GitHub Impact
The required
CI Gatecontext remains stable. This changes what it accepts: dependency, behavior, deployment, and unclassified changes must now complete the appropriate Fast Checks lane. Draft PRs and explicitly documentation-only changes retain intentional skip handling.Closes #148