Skip to content

Make the required CI gate fail closed#162

Merged
jmcte merged 2 commits into
mainfrom
codex/ci-gate-governance
Jul 11, 2026
Merged

Make the required CI gate fail closed#162
jmcte merged 2 commits into
mainfrom
codex/ci-gate-governance

Conversation

@jmcte

@jmcte jmcte commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • classify behavior, documentation-only, and unknown changes explicitly in the required PR gate
  • run Fast Checks for source, tests, deployment configuration, runner images, local actions, dependencies, and fail-closed unknown paths
  • keep same-repository and fork execution isolated while requiring the correct lane to succeed
  • align extended validation and bootstrap metadata with the pnpm and Node 24 project baseline

Validation

  • pnpm exec vitest run test/workflow.test.ts (14 tests passed)
  • CI=true bash scripts/ci/run-fast-checks.sh (48 files, 268 tests; lint and build passed)
  • actionlint (passed with known custom-runner-label diagnostics ignored)
  • git diff --check

Synology / GitHub Impact

  • no deploy impact
  • compose/config change
  • image rebuild or republish required
  • GitHub settings or runner-group change required

The required CI Gate context remains stable. This changes what it accepts: dependency, behavior, deployment, and unclassified changes must now complete the appropriate Fast Checks lane. Draft PRs and explicitly documentation-only changes retain intentional skip handling.

Closes #148

Classify behavior, documentation, and unknown paths explicitly so source, deployment, dependency, and unrecognized changes cannot satisfy branch protection without meaningful checks. Align extended validation and bootstrap metadata with the pnpm and Node 24 project baseline.

Closes #148
@jmcte jmcte requested a review from a team as a code owner July 10, 2026 19:03
@jmcte jmcte enabled auto-merge (squash) July 10, 2026 19:23

@athena-omt athena-omt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Governance review: live head 0f8150e is fresh enough for review, required checks are green, and auto-merge is already enabled.

I reviewed the fail-closed CI gate classification for behavior/docs/unknown changes, same-repo vs fork job expectations, and the workflow/bootstrap contract tests. I did not find a blocker.

@jmcte jmcte merged commit ab3ffae into main Jul 11, 2026
17 checks passed
@jmcte jmcte deleted the codex/ci-gate-governance branch July 11, 2026 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make CI Gate run tests for every behavior and deployment change

2 participants