Always reformat .toml files in commands reading them#249
Open
GBertholon wants to merge 1 commit into
Open
Conversation
Due to internal implementation details, some but not all options of drom project, drom new, drom package and drom dep were implicitly reformatting all .toml files in the project, creating annoying to review reformatting changes everywhere. After this commit we always reformat .toml files in those 4 subcommands. Effectively, this corresponds to having the (now removed) --upgrade flag always on. Since each modified .toml file will be instantly reformatted by the next drom command reading it this will avoid formatting changes later in the git history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to internal implementation details, some but not all options of
drom project,drom new,drom packageanddrom depwere implicitly reformatting all .toml files in the project, creating annoying to review reformatting changes everywhere.After this commit we always reformat .toml files in those 4 subcommands. Effectively, this corresponds to having the (now removed)
--upgradeflag always on.Since each modified .toml file will be instantly reformatted by the next drom command reading it this will avoid formatting changes later in the git history.