Repository navigation
[19.0] web_company_color: forward ports from 18.0 - #3765
Open
MiquelRForgeFlow wants to merge 9 commits into
Open
MiquelRForgeFlow wants to merge 9 commits into
MiquelRForgeFlow wants to merge 9 commits into
Conversation
Using a function to fetch SCSS_TEMPLATE
Otherwise function calls are not evaluated in the created attachment
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
@MarwanBHL can you check the CLA? |
Done ! |
Contributor
|
Can you add this changes? #3759 |
The company scss link was added inside the methods whose result is stored by ormcache (`_generate_asset_links_cache` / `_generate_asset_links`). The cache key does not depend on the company, and the override changed the cached list in place with `+=`. Each request added its company scss to the shared list, so the colors shown were those of the last company added in that worker. Now the company scss is added in `_get_asset_links`, which is not cached, and a new list is returned without changing the cached one.
Contributor
Author
Done. |
pedrobaeza
approved these changes
Oct 29, 2026
CarlosRoca13
approved these changes
Oct 29, 2026
Contributor
|
/ocabot merge patch |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
It looks like something changed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward ports of: