Repository navigation
Conversation
OCA-git-bot
added
series:19.0
mod:web_widget_open_tab
MohamedOsman7
left a comment
MohamedOsman7
left a comment
There was a problem hiding this comment.
Tested in Runboat. LGTM
|
@BhaveshHeliconia can you please review/approve? |
|
You shouldn't add the AI agent as a co-author. It should be mentioned as assisted by AI according to the OCA AI policy: https://github.com/OCA/.github/blob/master/AI_POLICY.md |
…inside other forms
Currently translated at 100.0% (6 of 6 strings) Translation: web-16.0/web-16.0-web_widget_open_tab Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_widget_open_tab/es/
Assisted-by: Claude Fable 5.1 <noreply@anthropic.com>
f1f6507 to
b1f8c91
Compare
| @@ -1,2 +0,0 @@ | |||
| from . import ir_model | |||
| from . import ir_ui_view | |||
There was a problem hiding this comment.
Is there a reason why models/ and tests/ and views/ were removed in this PR?
There was a problem hiding this comment.
Yes, mentioned in the PR description.
Initially this module was discarded in total, because it its not needed in the list view anymore.
I've identified a use case for the widget, so I've remigrated this module discarding only the obsolete part.
| <field name="inherit_id" ref="base.view_users_tree" /> | ||
| <field name="arch" type="xml"> | ||
| <field name="name" position="before"> | ||
| <field name="id" widget="open_tab" /> |
There was a problem hiding this comment.
| <field name="id" widget="open_tab" /> | |
| <field name="id" widget="open_tab" nolabel="1" /> |
In list views, missing nolabel="1" prints "ID" as the column title above the button. Adding nolabel="1" keeps the header clean.
|
|
||
| You can open the record in a new tab when clicking with the mouse wheel | ||
| on the external link icon. On a usual click the record will be opened | ||
| without changes (keeping the breadcrumbs). |
There was a problem hiding this comment.
| without changes (keeping the breadcrumbs). | |
| Clicking on the external link icon (left-click or middle-click) opens the record directly in a new tab. |
The link uses target="_blank", so a regular click always opens in a new tab. The old text saying it opens in the same window keeping breadcrumbs is outdated.
I am aware that #3386 came to the conclusion that this module is not needed. Therefore I've removed extension on the list view.
The open_tab widget is still usefull. There is a bug (odoo/odoo#295898) in the kanban view, which prevents using the middle mouse key to open a link in a new tab on Edge (or in general chrome based browsers).
Therefore the open_tab widget is still helpful until the fix is applied (if ever).
cc: @MohamedOsman7