[ADD] migration_pr_check: Remind migration guidelines

[SirPyTech]

Superseding #220 because https://github.com/SirTakobi is no more active.

[HekkiMelody]

Code review, LGTM

[legalsylvain]

Thanks !

[rousseldenis]

This seems great! Thanks!

[rousseldenis]

@OCA/core-maintainers

[rousseldenis]

@SirPyTech Do you have studied the possibility to add the migration tag on the PR too ?

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[SirPyTech]

@SirPyTech Do you have studied the possibility to add the migration tag on the PR too ?

Thanks for having a look!
No because that and other PR management tasks are already in the ocabot migration command.
This PR's purpose is to add a little automated guidance to the contributor proposing a migration.

[hbrunn]

...but given you detect which module is added anyways, wouldn't it be great if the bot writes

/ocabot migration $module

too? I think it has write permissions, so this should actually work.

I can imagine some other stuff I'd like to see eventually, like actually enforcing all of the module's commits exist in the PR, but that would be future extensions I think.

[OCA-git-bot]

Hi @hbrunn. Your command failed:

Invalid options for command migration: .

Ocabot commands

• ocabot merge major|minor|patch|nobump
• ocabot rebase
• ocabot migration {MODULE_NAME}

More information

• ocabot documentation
• OCA guidelines, specially the "Version Numbers" section.

[legalsylvain]

...but given you detect which module is added anyways, wouldn't it be great if the bot writes

this could save a lot of time for PSC ! 👍 if it's possible easily.

[etobella]

...but given you detect which module is added anyways, wouldn't it be great if the bot writes

this could save a lot of time for PSC ! 👍 if it's possible easily.

Another benefit is that bot is able to detect easily if another migration exists 🤔

[SirPyTech]

...but given you detect which module is added anyways, wouldn't it be great if the bot writes

/ocabot migration $module

too? I think it has write permissions, so this should actually work.

...but given you detect which module is added anyways, wouldn't it be great if the bot writes

this could save a lot of time for PSC ! 👍 if it's possible easily.

Right now the message is completely static so it would require a bit of refactoring.
I'd also like to see how adding this simple comment performs before adding active features.

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[legalsylvain]

/ocabot merge nobump

Edit, I'll deploy in my server to make a test, before merging.

[legalsylvain]

hi @SirPyTech. I deployed in GRAP production. The bot doesn't write a comment. Did I missed something ?

grap/grap-odoo-incubator#235

Thanks for your help !

[SirPyTech]

hi @SirPyTech. I deployed in GRAP production. The bot doesn't write a comment. Did I missed something ?

grap/grap-odoo-incubator#235

Thanks for your help !

The PR's title has [MIG] so it should be detected as a migration, maybe you have switched on only some tasks and not the new one? The task has the usual decorator @switchable("comment_migration_guidelines").

You can also try setting a message explicitly with the environment variable MIGRATION_GUIDELINES_REMINDER.

[legalsylvain]

here is the configuration.
the rebase_bot, mention_maintainer, merge_bot are working for the time being, so comment_migration_guidelines should work also. Don't you think ?

# Coma separated list of task to run
# By default all configured tasks are run.
# Available tasks:
#  delete_branch,tag_approved,tag_ready_to_merge,gen_addons_table,
#  gen_addons_readme,gen_addons_icon,setuptools_odoo,mention_maintainer,
#  merge_bot,rebase_bot,merge_bot_towncrier,tag_needs_review
#BOT_TASKS=all

# Coma separated list of task to ignore
BOT_TASKS_DISABLED=gen_addons_icon,setuptools_odoo

[SirPyTech]

here is the configuration. the rebase_bot, mention_maintainer, merge_bot are working for the time being, so comment_migration_guidelines should work also. Don't you think ?

# Coma separated list of task to run
# By default all configured tasks are run.
# Available tasks:
#  delete_branch,tag_approved,tag_ready_to_merge,gen_addons_table,
#  gen_addons_readme,gen_addons_icon,setuptools_odoo,mention_maintainer,
#  merge_bot,rebase_bot,merge_bot_towncrier,tag_needs_review
#BOT_TASKS=all

# Coma separated list of task to ignore
BOT_TASKS_DISABLED=gen_addons_icon,setuptools_odoo

Yes based on that configuration I think it should work