[ADD] contract_invoice_company_domain - #1500
Open
tobiaszehntner wants to merge 1 commit into
Open
Conversation
tobiaszehntner
marked this pull request as draft
August 20, 2026 09:26
OCA-git-bot
added
series:18.0
mod:contract_invoice_company_domain
tobiaszehntner
force-pushed
the
18.0-contract-invoice-company-domain
branch
3 times, most recently
from
August 21, 2026 10:43
f412580 to
2284a9d
Compare
tobiaszehntner
force-pushed
the
18.0-contract-invoice-company-domain
branch
from
August 21, 2026 10:57
2284a9d to
cd3beb9
Compare
tobiaszehntner
marked this pull request as ready for review
August 21, 2026 11:03
acsonefho
reviewed
Aug 25, 2026
| if extra_domain: | ||
| # The extra domain restricts this company's contracts only. | ||
| company_clauses.append( | ||
| expression.OR([[("company_id", "!=", company.id)], extra_domain]) |
There was a problem hiding this comment.
Should be:
company_clauses.append(expression.AND([[("company_id", "=", company.id)], extra_domain]))
?
Contributor
Author
There was a problem hiding this comment.
no because the company_clauses are ANDed together below, so it would exclude contracts of other companies. Other companies should still have their contracts invoiced , and the extra domain should apply to this specific company only, hence [(company != X) OR company-domain]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This module lets each company control which of its contracts are picked
up by the recurring invoices cron.
Per company you can:
of the domains contributed by the standard flow and other contract
modules.
AI: