[18.0][ADD]contract_invoice_suspended

[bjouini-acsone]

No description provided.

[qgroulard]

Hi, thanks for this contribution !

It would be nice to provide a bit more context 🙂

[qgroulard]

Please follow oca guidelines: https://www.odoo-community.org/readme-structure

Could you please also elaborate? What's the point of this module? How to configure it? etc.
Try to think of this module as if it was completely unknown to you, what would you like to know about it?

[bjouini-acsone]

is it okay like this ?

[qgroulard]

Not quite, please see the documentation: https://www.odoo-community.org/readme-structure

There are dedicated fragments for "Usage" and "Configure", they should not be sub-section of the "Description" fragment.

[bjouini-acsone]

refactored this , is this okay now ?

[qgroulard]

Why are these two separated?

[bjouini-acsone]

fixed

[qgroulard]

The new convention for multi-company rule is:

        [('company_id', 'in', company_ids + [False])]

[bjouini-acsone]

refactored

[qgroulard]

This looks super complicated to me.
Why can't we do something like:

Suggested change

	@api.depends("parent_id.suspended_reason_category_id")
	def _compute_suspended_reason_category_id(self):
	self.env.cr.execute(
	"""
	WITH RECURSIVE trid(id, parent_id,
	suspended_reason_category_id, final) AS (
	SELECT
	id, parent_id, id,
	(parent_id IS NULL) as final
	FROM contract_automatic_invoice_suspension_reason
	WHERE id = ANY(%s)
	UNION
	SELECT
	trid.id, ctr.parent_id, ctr.id,
	(ctr.parent_id IS NULL) as final
	FROM contract_automatic_invoice_suspension_reason ctr
	JOIN trid ON (trid.parent_id = ctr.id)
	WHERE NOT trid.final
	)
	SELECT trid.id, trid.suspended_reason_category_id
	FROM trid
	WHERE final AND id = ANY(%s);
	""",
	[self.ids, self.ids],
	)
	d = dict(self.env.cr.fetchall())
	for suspension_reason in self:
	fetched = d.get(suspension_reason.id)
	if fetched is not None:
	suspension_reason.suspended_reason_category_id = fetched
	elif not suspension_reason.parent_id:
	suspension_reason.suspended_reason_category_id = suspension_reason
	else:
	suspension_reason.suspended_reason_category_id = (
	suspension_reason.parent_id.suspended_reason_category_id
	)
	@api.depends("parent_id.suspended_reason_category_id")
	def _compute_suspended_reason_category_id(self):
	for suspension_reason in self:
	suspension_reason.suspended_reason_category_id = (
	suspension_reason.parent_id.suspended_reason_category_id
	or suspension_reason
	)

[bjouini-acsone]

yes , refactored

[qgroulard]

This was a genuine question. Are you 100% sure this is correct and efficient?

[bjouini-acsone]

i tested it works fine also if i understood well the functionality also this test is paasing fine ,test_compute_suspended_reason_category_id