[19.0][OU-ADD] hr_attendance + hr_recruitment_skills: pre-migration column renames#5635
Closed
dnplkndll wants to merge 1 commit into
Closed
[19.0][OU-ADD] hr_attendance + hr_recruitment_skills: pre-migration column renames#5635dnplkndll wants to merge 1 commit into
dnplkndll wants to merge 1 commit into
Conversation
OCA-git-bot
added
mod:openupgrade_scripts
dnplkndll
force-pushed
the
19.0-mig-hr-family-overtime-skills
branch
2 times, most recently
from
376a431 to
ada78a5
Compare
dnplkndll
force-pushed
the
19.0-mig-hr-family-overtime-skills
branch
3 times, most recently
from
5e2eb6c to
0ce47ad
Compare
dnplkndll
force-pushed
the
19.0-mig-hr-family-overtime-skills
branch
from
0ce47ad to
6cac1d5
Compare
dnplkndll
changed the title
Contributor
Author
|
ready for review @MiquelRForgeFlow @pedrobaeza |
dnplkndll
force-pushed
the
19.0-mig-hr-family-overtime-skills
branch
7 times, most recently
from
2a2a542 to
e9c545c
Compare
hbrunn
requested changes
Jun 2, 2026
dnplkndll
force-pushed
the
19.0-mig-hr-family-overtime-skills
branch
4 times, most recently
from
7a9ce8e to
bd68584
Compare
Contributor
Author
|
thanks @hbrunn all addressed in the latest push |
dnplkndll
force-pushed
the
19.0-mig-hr-family-overtime-skills
branch
3 times, most recently
from
bd68584 to
f8b5f8f
Compare
- hr_attendance: hr.attendance.overtime → .overtime.line (rename_models + rename_tables); noupdate group/rule reloaded in post-migration. - hr_attendance: rename hr.attendance in_city→in_location, out_city→out_location (preserve data; analyzer reports them as separate DEL+NEW). - hr_attendance: precreate hr.attendance.overtime.line.status='approved' and manual_duration=duration on the renamed table's historical rows; backfill the now-required date. The status compute guards on `if not status`, so precreating keeps legacy lines approved instead of recomputing to to_approve. - hr_attendance: delete the obsolete noupdate ir.rule records (not swept by the standard module update). - hr_holidays_attendance: drop hr.leave / hr.leave.allocation overtime_id — the field is removed in 19.0 and the overtime rename invalidated its FK. - hr_recruitment_skills: hr.candidate.skill → hr.applicant.skill rename; noupdate interviewer/officer rules reloaded. - hr_holidays_attendance, hr_skills: noupdate security/config reloaded.
dnplkndll
force-pushed
the
19.0-mig-hr-family-overtime-skills
branch
from
f8b5f8f to
0e3e927
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-migration column-rename scripts for two model-rename refactors in 4
hr_*submodules:hr_attendance,hr_holidays_attendance,hr_skills,hr_recruitment_skills. Companion to #5634 (13 simple submodules).Two model renames already in
apriori.renamed_models:hr.attendance.overtime→hr.attendance.overtime.line(hr_attendance, hr_holidays_attendance)hr.candidate.skill→hr.applicant.skill(hr_recruitment_skills)Apriori handles both via
update_module_names/rename_modelsin base/19.0.1.3/pre-migration. Plus a small pre-migration inhr_recruitment_skillsto seed thehr_applicant_hr_skill_reljoin table from the legacy table name.