Skip to content

cmake: make the installed package consumable #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
petlenz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

cmake: make the installed package consumable #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef6d2ac
cmake: make the installed package consumable
Aug 22, 2026
b75a462
cmake: drop the now-dead header list
Aug 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,21 +27,6 @@ set(${PROJECT_NAME}_VERSION ${project_version})
message(STATUS "Building v${${PROJECT_NAME}_VERSION}")

# Header files
set(${PROJECT_NAME}_HEADER
${${PROJECT_NAME}_INCLUDE_DIR}/factory_base_bones.h
${${PROJECT_NAME}_INCLUDE_DIR}/registry_bones.h
${${PROJECT_NAME}_INCLUDE_DIR}/warehouse_bones.h
${${PROJECT_NAME}_INCLUDE_DIR}/input_parameter_controller.h
${${PROJECT_NAME}_INCLUDE_DIR}/input_parser.h
${${PROJECT_NAME}_INCLUDE_DIR}/static_indexing.h
${${PROJECT_NAME}_INCLUDE_DIR}/numsim_core_utility.h
${${PROJECT_NAME}_INCLUDE_DIR}/query_map.h
${${PROJECT_NAME}_INCLUDE_DIR}/parameter_handler.h
${${PROJECT_NAME}_INCLUDE_DIR}/any_printer.h
${${PROJECT_NAME}_INCLUDE_DIR}/wrapper.h
${${PROJECT_NAME}_INCLUDE_DIR}/input_parameter_enum_utils.h
${${PROJECT_NAME}_INCLUDE_DIR}/function_registry.h
)

# numsim-core is header-only: no sources, no compiled artefacts, just an
# INTERFACE target carrying include paths + a C++23 feature requirement
Expand All @@ -56,6 +41,14 @@ set(${PROJECT_NAME}_HEADER
add_library(${PROJECT_NAME} INTERFACE)
add_library(${PROJECT_NAME}::${PROJECT_NAME} ALIAS ${PROJECT_NAME})

# GNUInstallDirs BEFORE the target_include_directories() below, not after it.
# CMAKE_INSTALL_INCLUDEDIR is expanded when the line is read, so with the
# include further down the INSTALL_INTERFACE expanded EMPTY and the exported
# target carried no include directory at all -- consumers of the installed
# package could find it and not compile against it. An empty INSTALL_INTERFACE
# is legal, so nothing warned.
include(GNUInstallDirs)

# Headers are reachable from the build tree and from the install tree.
target_include_directories(${PROJECT_NAME}
INTERFACE
Expand All @@ -78,7 +71,6 @@ option(DOWNLOAD_GTEST "Download and build GTest" OFF)
option(DOWNLOAD_GBENCHMARK "Download and build Google Benchmark" OFF)

# Installation logic
include(GNUInstallDirs)
if(${PROJECT_NAME}_INSTALL_LIBRARY)
install(
TARGETS ${PROJECT_NAME}
Expand All @@ -89,8 +81,14 @@ if(${PROJECT_NAME}_INSTALL_LIBRARY)
)

# Install header files
install(FILES ${${PROJECT_NAME}_HEADER}
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/${PROJECT_NAME})
# install(DIRECTORY), not install(FILES): FILES flattens everything into
# one directory, so include/numsim-core/property_graph/*.h landed beside
# the top-level headers and #include <numsim-core/property_graph/...>
# could not resolve. It also only installed the files listed in
# a hand-maintained list -- 13 of the 23 headers in the tree.
install(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/include/
DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
FILES_MATCHING PATTERN "*.h")

# Create and install package config files
include(CMakePackageConfigHelpers)
Expand Down
Loading