Deduplicate target emission helpers (#139) - #159
Open
petlenz wants to merge 1 commit into
Open
Conversation
Member
Author
|
No CI checks appear here by design: build.yml triggers only on PRs targeting main, and this PR's base is fix-137-can-emit (stacked). Validated locally (gcc-14 Debug -Werror, ctest 331/331). Once #158 merges and this is retargeted to main (REST PATCH), the full matrix runs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #139 (largest items; two smaller ones remain — see below).
STACKED PR — base is
fix-137-can-emit(PR #158), NOT main. Merge #158 first, then retarget this to main (REST PATCH, notgh pr edit— the latter silently no-ops on this org) or merge as-is after #158 lands.collect_scalar_params/collect_tensor_inputs(CollectedSymbols + structured bindings),reject_non_finite_default,emit_parameters_schema(...)parameterized on thesolver_source/integrator_sourcedifference, andMemberUniquenessGuard::claim.uses_linear_algebra(body, la)(linear_algebra_emitter.h) anduses_spectral_runtime(body)(spectral_decompose_emit.h) replace the verbatim include-gating logic duplicated across standalone_cxx.cpp and moose_material.cpp.Emitted text proven byte-identical: full suite green with zero test edits (the exact-substring assertions + compile-check drivers are the oracle), plus a
diff -rof the standalone registry output regenerated before/after — clean.Remaining #139 scope (follow-up): the
EmittedOutput/register_*local-structure pair in numsim_material.cpp.gcc-14 Debug (-Werror): ctest 331/331.