#4254 task labels#4256
Open
wavehassman wants to merge 17 commits into
Open
Conversation
chpy04
requested changes
Jun 5, 2026
| } | ||
| } | ||
|
|
||
| static async getTasksByWbsNumAndLabels(req: Request, res: Response, next: NextFunction) { |
Contributor
There was a problem hiding this comment.
why would we not just use the existing filter endpoint and add labels to that?
Contributor
Author
There was a problem hiding this comment.
The filter endpoint is scoped to the calendar view, so it requires a date range and returns CalendarTask[] which has lead/manager fields needed for calendar permissions
I don't think it makes sense to join the two since they are totally different use cases
| * @param organization the organization that the user is currently in | ||
| * @returns array of tasks that have at least one matching label | ||
| */ | ||
| static async getTasksByWbsNumAndLabels( |
Contributor
There was a problem hiding this comment.
yeah we should really move the labels part of this to the filters endpoint. Filtering by wbs is a seperate endpoint because that is what we are inherently doing on every page, but that is not the case for labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds a full task labels feature:
Test Cases
Setting labels on a task:
Create task label:
Edit task label:
Delete task label:
Screenshots
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4254